Open
Conversation
ckgod
reviewed
Aug 5, 2022
| android:layout_width="wrap_content" | ||
| android:layout_height="30dp" | ||
| android:text="박예선님, 상큼달콤한 여름 스무디를 즐겨보세요" | ||
| android:textSize="14sp" |
Collaborator
There was a problem hiding this comment.
TextView마다 textSize를 어떤애는 sp를 쓰고, 또 다른애는 dp를 쓰는데 sp와 dp의 차이 공부해보면 좋을 것 같아
ckgod
reviewed
Aug 5, 2022
Comment on lines
+12
to
+25
| <TextView | ||
| android:id="@+id/grade" | ||
| android:layout_width="120dp" | ||
| android:layout_height="30dp" | ||
| android:background="@drawable/round" | ||
| android:layout_marginTop="20dp" | ||
| android:text=" SILVER" | ||
| android:textStyle="bold" | ||
| android:textSize="16sp" | ||
| android:textColor="@color/white" | ||
| app:layout_constraintTop_toTopOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| /> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <TextView | |
| android:id="@+id/grade" | |
| android:layout_width="120dp" | |
| android:layout_height="30dp" | |
| android:background="@drawable/round" | |
| android:layout_marginTop="20dp" | |
| android:text=" SILVER" | |
| android:textStyle="bold" | |
| android:textSize="16sp" | |
| android:textColor="@color/white" | |
| app:layout_constraintTop_toTopOf="parent" | |
| app:layout_constraintEnd_toEndOf="parent" | |
| app:layout_constraintStart_toStartOf="parent" | |
| /> | |
| <TextView | |
| android:id="@+id/grade" | |
| android:layout_width="120dp" | |
| android:layout_height="30dp" | |
| android:background="@drawable/round" | |
| android:layout_marginTop="20dp" | |
| android:text="SILVER" | |
| android:textStyle="bold" | |
| android:textSize="16sp" | |
| android:textColor="@color/white" | |
| app:layout_constraintTop_toTopOf="parent" | |
| app:layout_constraintEnd_toEndOf="parent" | |
| app:layout_constraintStart_toStartOf="parent" | |
| app:drawableEndCompat="@drawable/barcode_resize" | |
| android:paddingHorizontal="10dp" | |
| android:gravity="center_vertical" | |
| android:includeFontPadding="false"/> |
TextView에 이미지 넣는 속성값 있으니까 이거 사용해보는 것도 좋아
" SILVER" 이런거는 마진이나 패딩 사용하기
drawble/barcode_resize
<?xml version="1.0" encoding="utf-8"?>
<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
<item
android:drawable="@drawable/barcode"
android:width="30dp"
android:height="20dp" />
</layer-list>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.